Skip to content

Commit

Permalink
Removed obsolete tampered characteristic.
Browse files Browse the repository at this point in the history
  • Loading branch information
Marc Sowen committed Mar 13, 2021
1 parent 131f606 commit 12024f2
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 4 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 0.3.5 (2021-03-13)

### Improvements

- **SmokeDetector**: Removed obsolete tampered characteristic.

## 0.3.4 (2021-03-13)

### Bugfix
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "homebridge-homematicip",
"version": "0.3.4",
"version": "0.3.5",
"description": "Homematic IP plugin for homebridge",
"license": "Apache-2.0",
"author": "Marc Sowen <[email protected]>",
Expand Down
5 changes: 5 additions & 0 deletions src/devices/HmIPSmokeDetector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ export class HmIPSmokeDetector extends HmIPGenericDevice implements Updateable {
this.service = this.accessory.getService(this.platform.Service.SmokeSensor) || this.accessory.addService(this.platform.Service.SmokeSensor);
this.service.setCharacteristic(this.platform.Characteristic.Name, accessory.context.device.label);

if (this.service.testCharacteristic(this.platform.Characteristic.StatusTampered)) {
this.platform.log.info("Removing obsolete tampered characteristic from %s", accessory.context.device.label);
this.service.removeCharacteristic(this.service.getCharacteristic(this.platform.Characteristic.StatusTampered));
}

this.updateDevice(accessory.context.device, platform.groups);

this.service.getCharacteristic(this.platform.Characteristic.SmokeDetected)
Expand Down
2 changes: 1 addition & 1 deletion src/settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ export const PLUGIN_NAME = 'homebridge-homematicip';
/**
* Version to be used in protocol communication
*/
export const PLUGIN_VERSION = '0.3.4';
export const PLUGIN_VERSION = '0.3.5';

0 comments on commit 12024f2

Please sign in to comment.