Add support for max_completion_tokens property #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `MaxCompletionTokens` property to `appsettings.json`, `ChatGptParameters.cs`, and `ChatGptRequest.cs`. Modified `ChatGptClient.cs` to handle `MaxCompletionTokens` and set `MaxTokens` to null if it is set.
Updated README.md to list new models (`o1-preview` and `o1-mini`) and revised configuration examples to use `MaxCompletionTokens`. Updated appsettings.json to reflect the new `MaxCompletionTokens` property in configuration examples. Added constants for new models in OpenAIChatGptModels.cs with descriptions and token support details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to support new
o1series models, deprecate theMaxTokensproperty in favor ofMaxCompletionTokens, and update various package dependencies. The most important changes are summarized below:Support for
o1Series Models:o1-previewando1-minimodels to the list of available models inREADME.mdandOpenAIChatGptModels.cs. [1] [2]ChatGptParametersandChatGptRequestclasses to include the newMaxCompletionTokensproperty, with deprecation notes forMaxTokens. [1] [2]Code Updates:
CreateChatGptRequestmethod inChatGptClient.csto handle the conditional use ofMaxCompletionTokensforo1series models. [1] [2] [3]Documentation Updates:
README.mdandappsettings.jsonfiles to explain the use ofMaxCompletionTokensforo1series models. [1] [2] [3] [4] [5]Dependency Updates:
ChatGptApi.csproj,ChatGptBlazor.Wasm.csproj,Directory.Build.props). [1] [2] [3]Closes #167