Skip to content

Commit

Permalink
Backed out changeset aa66fda02aac (bug 1668136) for causing failures …
Browse files Browse the repository at this point in the history
…on content-visibility. CLOSED TREE

UltraBlame original commit: bc715251fc27da8e06b30c890b5383cb4dc88c85
  • Loading branch information
marco-c committed Nov 1, 2023
1 parent f66be6a commit e0b91b7
Show file tree
Hide file tree
Showing 16 changed files with 168 additions and 2,700 deletions.
92 changes: 0 additions & 92 deletions dom/base/DOMIntersectionObserver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5674,81 +5674,6 @@ thresholdIndex
}
/
/
If
descendantScrolledIntoView
it
means
the
target
is
with
c
-
v
:
auto
and
/
/
the
content
relevancy
value
has
been
set
to
visible
before
/
/
scrollIntoView
.
Here
we
need
to
generate
entries
for
them
so
that
the
/
/
content
relevancy
value
could
be
checked
in
the
callback
.
const
bool
temporarilyVisibleForScrolledIntoView
=
isContentVisibilityObserver
=
=
IsContentVisibilityObserver
:
:
Yes
&
&
target
-
>
TemporarilyVisibleForScrolledIntoViewDescendant
(
)
;
/
/
Steps
2
.
Expand All @@ -5768,9 +5693,6 @@ UpdateIntersectionObservation
this
thresholdIndex
)
|
|
temporarilyVisibleForScrolledIntoView
)
{
/
Expand Down Expand Up @@ -5843,20 +5765,6 @@ thresholdIndex
intersectionRatio
)
;
if
(
temporarilyVisibleForScrolledIntoView
)
{
target
-
>
SetTemporarilyVisibleForScrolledIntoViewDescendant
(
false
)
;
}
}
}
}
Expand Down
49 changes: 0 additions & 49 deletions dom/base/Element.h
Original file line number Diff line number Diff line change
Expand Up @@ -8537,56 +8537,7 @@ reset
(
)
;
slots
-
>
mTemporarilyVisibleForScrolledIntoViewDescendant
=
false
;
}
}
bool
TemporarilyVisibleForScrolledIntoViewDescendant
(
)
const
{
const
auto
*
slots
=
GetExistingExtendedDOMSlots
(
)
;
return
slots
&
&
slots
-
>
mTemporarilyVisibleForScrolledIntoViewDescendant
;
}
void
SetTemporarilyVisibleForScrolledIntoViewDescendant
(
bool
aVisible
)
{
ExtendedDOMSlots
(
)
-
>
mTemporarilyVisibleForScrolledIntoViewDescendant
=
aVisible
;
}
/
/
Expand Down
30 changes: 0 additions & 30 deletions dom/base/FragmentOrElement.h
Original file line number Diff line number Diff line change
Expand Up @@ -1283,36 +1283,6 @@ mVisibleForContentVisibility
*
*
*
Whether
content
-
visibility
:
auto
is
temporarily
visible
for
*
the
purposes
of
the
descendant
of
scrollIntoView
.
*
/
bool
mTemporarilyVisibleForScrolledIntoViewDescendant
=
false
;
/
*
*
*
Explicitly
set
attr
Expand Down
Loading

0 comments on commit e0b91b7

Please sign in to comment.