Skip to content

Commit

Permalink
Bug 1857926: re-add OnStart/StopRequest Telemetry to monitor delay r=…
Browse files Browse the repository at this point in the history
…acreskey,necko-reviewers,valentin

Differential Revision: https://phabricator.services.mozilla.com/D190469

UltraBlame original commit: 1645fbba770b4bcf1ef910d4fb0d18ce2e58cf57
  • Loading branch information
marco-c committed Oct 30, 2023
1 parent f0fd6fe commit 88e72ea
Show file tree
Hide file tree
Showing 2 changed files with 254 additions and 12 deletions.
186 changes: 186 additions & 0 deletions netwerk/metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -911,6 +911,192 @@ never
telemetry_mirror
:
DNS_FAILED_LOOKUP_TIME
http_content_onstart_delay
:
type
:
timing_distribution
time_unit
:
millisecond
description
:
>
The
time
between
dispatching
OnStartRequest
from
the
socket
thread
and
processing
it
on
the
main
thread
(
content
process
)
.
bugs
:
-
https
:
/
/
bugzilla
.
mozilla
.
org
/
show_bug
.
cgi
?
id
=
1857926
data_reviews
:
-
https
:
/
/
bugzilla
.
mozilla
.
org
/
show_bug
.
cgi
?
id
=
1857926
#
c
data_sensitivity
:
-
technical
notification_emails
:
-
necko
mozilla
.
com
-
rjesup
mozilla
.
com
expires
:
130
http_content_onstop_delay
:
type
:
timing_distribution
time_unit
:
millisecond
description
:
>
The
time
between
dispatching
OnStopRequest
from
the
socket
thread
and
processing
it
on
the
main
thread
(
content
process
)
.
bugs
:
-
https
:
/
/
bugzilla
.
mozilla
.
org
/
show_bug
.
cgi
?
id
=
1857926
data_reviews
:
-
https
:
/
/
bugzilla
.
mozilla
.
org
/
show_bug
.
cgi
?
id
=
1857926
#
c
data_sensitivity
:
-
technical
notification_emails
:
-
necko
mozilla
.
com
-
rjesup
mozilla
.
com
expires
:
130
http_1_download_throughput
:
type
Expand Down
80 changes: 68 additions & 12 deletions netwerk/protocol/http/HttpChannelChild.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1702,6 +1702,16 @@ OnSocketThread
)
)
;
TimeStamp
start
=
TimeStamp
:
:
Now
(
)
;
mAltDataInputStream
=
DeserializeIPCStream
Expand Down Expand Up @@ -1736,17 +1746,35 @@ aResponseHead
aUseResponseHead
aRequestHeaders
aArgs
aOnStartRequestStartTime
start
]
(
)
{
self
-
>
mOnStartRequestStartTime
TimeDuration
delay
=
aOnStartRequestStartTime
TimeStamp
:
:
Now
(
)
-
start
;
glean
:
:
networking
:
:
http_content_onstart_delay
.
AccumulateRawDuration
(
delay
)
;
self
-
Expand Down Expand Up @@ -4218,6 +4246,16 @@ encodedBodySize
)
;
}
TimeStamp
start
=
TimeStamp
:
:
Now
(
)
;
if
(
StaticPrefs
Expand Down Expand Up @@ -4322,18 +4360,36 @@ Clone
)
}
aFromSocketProcess
aOnStopRequestStartTime
start
]
(
)
mutable
{
self
-
>
mOnStopRequestStartTime
TimeDuration
delay
=
aOnStopRequestStartTime
TimeStamp
:
:
Now
(
)
-
start
;
glean
:
:
networking
:
:
http_content_onstop_delay
.
AccumulateRawDuration
(
delay
)
;
self
-
Expand Down

0 comments on commit 88e72ea

Please sign in to comment.