Skip to content

Commit

Permalink
Backed out changeset f334593f5b54 (bug 1877273) for causing non-unifi…
Browse files Browse the repository at this point in the history
…ed build bustages on UseCounterMetrics.cpp.

UltraBlame original commit: 82ef966ee2cb7bc65ca630633933207a43cb3f8b
  • Loading branch information
marco-c committed Feb 1, 2024
1 parent a8a8c27 commit 58d89ee
Show file tree
Hide file tree
Showing 12 changed files with 3,281 additions and 446 deletions.
321 changes: 314 additions & 7 deletions dom/base/Document.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -999,6 +999,15 @@ include
"
mozilla
/
TelemetryHistogramEnums
.
h
"
#
include
"
mozilla
/
TelemetryScalarEnums
.
h
Expand Down Expand Up @@ -76170,6 +76179,251 @@ mSandboxFlags
SANDBOXED_SCRIPTS
;
}
static_assert
(
size_t
(
eUseCounter_EndCSSProperties
)
-
size_t
(
eUseCounter_FirstCSSProperty
)
=
=
size_t
(
eCSSProperty_COUNT_with_aliases
)
"
We
should
have
the
right
amount
of
CSS
property
use
counters
"
)
;
static_assert
(
size_t
(
eUseCounter_Count
)
-
size_t
(
eUseCounter_FirstCountedUnknownProperty
)
=
=
size_t
(
CountedUnknownProperty
:
:
Count
)
"
We
should
have
the
right
amount
of
counted
unknown
properties
"
"
use
counters
"
)
;
static_assert
(
size_t
(
eUseCounter_Count
)
*
2
=
=
size_t
(
Telemetry
:
:
HistogramUseCounterCount
)
"
There
should
be
two
histograms
(
document
and
page
)
"
"
for
each
use
counter
"
)
;
#
define
ASSERT_CSS_COUNTER
(
id_
method_
)
\
static_assert
(
size_t
(
eUseCounter_property_
#
#
method_
)
-
\
size_t
(
eUseCounter_FirstCSSProperty
)
=
=
\
size_t
(
id_
)
\
"
Order
for
CSS
counters
and
CSS
property
id
should
match
"
)
;
#
define
CSS_PROP_PUBLIC_OR_PRIVATE
(
publicname_
privatename_
)
privatename_
#
define
CSS_PROP_LONGHAND
(
name_
id_
method_
.
.
.
)
\
ASSERT_CSS_COUNTER
(
eCSSProperty_
#
#
id_
method_
)
#
define
CSS_PROP_SHORTHAND
(
name_
id_
method_
.
.
.
)
\
ASSERT_CSS_COUNTER
(
eCSSProperty_
#
#
id_
method_
)
#
define
CSS_PROP_ALIAS
(
name_
aliasid_
id_
method_
.
.
.
)
\
ASSERT_CSS_COUNTER
(
eCSSPropertyAlias_
#
#
aliasid_
method_
)
#
include
"
mozilla
/
ServoCSSPropList
.
h
"
#
undef
CSS_PROP_ALIAS
#
undef
CSS_PROP_SHORTHAND
#
undef
CSS_PROP_LONGHAND
#
undef
CSS_PROP_PUBLIC_OR_PRIVATE
#
undef
ASSERT_CSS_COUNTER
void
Document
:
Expand Down Expand Up @@ -76326,6 +76580,16 @@ mUseCountersInitialized
=
true
;
static_assert
(
Telemetry
:
:
HistogramUseCounterCount
>
0
)
;
if
(
!
Expand Down Expand Up @@ -76506,6 +76770,18 @@ mReportedDocumentUseCounters
=
true
;
Telemetry
:
:
Accumulate
(
Telemetry
:
:
CONTENT_DOCUMENTS_DESTROYED
1
)
;
glean
:
:
Expand Down Expand Up @@ -76624,15 +76900,25 @@ uc
continue
;
}
const
char
*
metricName
auto
id
=
IncrementUseCounter
static_cast
<
Telemetry
:
:
HistogramID
>
(
Telemetry
:
:
HistogramFirstUseCounter
+
uc
false
*
2
)
;
if
Expand All @@ -76653,7 +76939,13 @@ s
\
n
"
metricName
Telemetry
:
:
GetHistogramName
(
id
)
urlForLogging
-
>
Expand All @@ -76663,6 +76955,21 @@ get
)
;
}
Telemetry
:
:
Accumulate
(
id
1
)
;
IncrementUseCounter
(
uc
false
)
;
}
}
void
Expand Down
8 changes: 2 additions & 6 deletions dom/base/UseCounterMetrics.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,7 @@ WorkerKind
:
uint8_t
;
const
char
*
void
IncrementUseCounter
(
UseCounter
Expand All @@ -44,9 +42,7 @@ bool
aIsPage
)
;
const
char
*
void
IncrementWorkerUseCounter
(
UseCounterWorker
Expand Down
Loading

0 comments on commit 58d89ee

Please sign in to comment.