-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch up scheduling of deferred deletions #3030
Open
TimSylvester
wants to merge
7
commits into
maplibre:main
Choose a base branch
from
WetDogWeather:batch-defer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bloaty Results (iOS) 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3030-compared-to-main.txt |
louwers
reviewed
Nov 19, 2024
Bloaty Results 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3030-compared-to-main.txtCompared to d387090 (legacy)
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3030-compared-to-legacy.txt |
Benchmark Results ⚡
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3030-compared-to-main.txt |
louwers
reviewed
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In each tile cache (one per tile source), released tiles are kept in a vector and scheduled for release all at once, at the end of
update
, which is called once per frame.The capture below is from ~150 seconds of the Android benchmark, 5300 frames. Of 384 total, it shows 138 instances of just one tile being scheduled, up to 3 instances of 13 being released at once. 440 total scheduled tasks were averted in this case, roughly half.
Manually zooming in and out on the same area for ~600 frames produces similar results.
If we only did the release after accumulating several tiles, we could reduce the number of tasks significantly more, but we might end up holding onto unused tiles for many frames in some cases.
Additionally, this avoids allocating ashared_ptr
for eachunique_ptr
to make it copyable along with the lambda capture, using a more generic move-only function wrapper.