Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump style spec to 19.1.0 #2503

Merged
merged 3 commits into from
May 10, 2023
Merged

Bump style spec to 19.1.0 #2503

merged 3 commits into from
May 10, 2023

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented May 10, 2023 •
edited
Loading

Related #2496

Changelog

19.1.0

✨ Features and improvements

  • Use D50 white point instead of D65 in HCL/LAB color spaces #146
  • Automated migration of not-CSS-Color-specification-compliant hsl color values #135

@birkskyum birkskyum requested a review from HarelM May 10, 2023 19:38
@HarelM
Copy link
Collaborator

HarelM commented May 10, 2023

There's a need to update the expected.png of hcl test for this to pass. but I'm sure you know that :-)

@birkskyum
Copy link
Member Author

Aah, right, it should be in place now.

@HarelM
Copy link
Collaborator

HarelM commented May 10, 2023

Can you share why you changed both the test and the image and not just the image?

@birkskyum
Copy link
Member Author

birkskyum commented May 10, 2023 •
edited
Loading

I changed the expression tests because they independently of the render test also were breaking due to these color changes.

@birkskyum birkskyum merged commit 2cff8cd into maplibre:main May 10, 2023
@birkskyum birkskyum mentioned this pull request May 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarelM HarelM HarelM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birkskyum @HarelM