-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add speed limit data returned by MapboxDirections.swift to the RouteProgress object #2114
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
113bd2e
Updated MapboxDirections.swift
1ec5 6dac368
add maximumSpeedLimit to the route attribute options.
avi-c d6875ad
Add accessors for prior, current, and next SpeedLimit along the Route…
avi-c 6f877ba
Add accessor for speed limits by route leg as well as current speed l…
avi-c 0d1a08d
Change speed limits to be associated with the distance traveled along…
avi-c b005f6f
Add a type alias for the SpeedLimit,Distance tuple. Eliminate the Spe…
avi-c e958d21
Do not request maximumSpeedLimit annotations when making a walking pr…
avi-c 9038460
guard against missing speed limit data before attempting to use it wh…
avi-c c1edaec
Replaced SpeedLimit with Measurement
1ec5 259649b
Updated unit tests
1ec5 8062b1b
Corrected unknown, infinite speed limit cases
1ec5 22e0703
Simplified speed limit access
1ec5 3339380
Updated changelog
1ec5 2a31257
Test speed limit access
1ec5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
profileIdentifier
is mutable, so technically it’s possible for the developer to change the profile identifier towalking
after initializing the object. We could address that case by conditionally addingmaximumSpeedLimit
in an override of theURLQueryItems
property instead of this initializer. But maybe it isn’t a big deal.