This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Tell what layer is failing on parsing errors #15856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will make it easier for debugging style issues.
pozdnyakov
approved these changes
Oct 24, 2019
|
@tmpsantos thanks for this addition, it will make our warnings much more useful. what about identifying the failing property -- do we have an idea of how that might be possible? |
|
@tmpsantos what is blocking this merge? |
Many unit tests failing because they expect a certain string on error, I will have to think of a better way to do this. :-( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will make it easier for debugging style issues.