fix: added missing export of CanvasSourceSpecification #13369
+10
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underoot
reviewed
Jan 17, 2025
| @@ -392,6 +392,13 @@ export type ModelSourceSpecification = { | |||
| "tiles"?: Array<string> | |||
| } | |||
|
|
|||
| export type CanvasSourceSpecification = { | |||
There was a problem hiding this comment.
CanvasSource is purely a GL JS runtime entity. Thus, it doesn't belong to the Style Specification. You can alternatively import the type from canvas_source.ts in src/source/source_types.ts it is a bit will change convention, but it reflects actual state anyway
underoot
reviewed
Jan 17, 2025
There was a problem hiding this comment.
It's automatically generated file from style-spec. See the header of file for the details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved
CanvasSourceSpecificationso that the type will be exported, similar toGeoJSONSourceSpecification,VideoSourceSpecificationand all other Source Specifications.https://docs.mapbox.com/mapbox-gl-js/api/sources/#canvassourceoptions
Launch Checklist
@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changes.@mapbox/gl-nativeif this PR includes shader changes or needs a native port.