Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix projection rotation adjustment when more than 180deg #11212

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

ansis
Copy link
Contributor

@ansis ansis commented Nov 3, 2021

Previously, it would correct to an upside down rotation if the rotation for locations where the rotation would have been more than 180 degrees. Reported by @JoshData in #3184 (comment)

Before

flip_old.mov

After

flip_new.mov

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'

Previously, it would correct to an upside down rotation if the rotation
for locations where the rotation would have been more than 180 degrees.
@ansis ansis added the skip changelog Used for PRs that do not need a changelog entry label Nov 3, 2021
@ansis ansis requested a review from mourner November 3, 2021 19:14
@JoshData
Copy link

JoshData commented Nov 3, 2021

Thanks for the @-mention. I'm glad the bug report was useful. Keep up the great work!

@ansis ansis merged commit 6aa1c4b into main Nov 3, 2021
@ansis ansis deleted the fix-rotation-flipping branch November 3, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Used for PRs that do not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants