Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

add restrict camera example #302

Merged
merged 4 commits into from
Apr 28, 2017
Merged

add restrict camera example #302

merged 4 commits into from
Apr 28, 2017

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Apr 26, 2017

This PR adds a Viewport limitation example from mapbox/mapbox-gl-native#3602. Since this feature is only found in the upcoming release, I bumped the SDK dependency to a SNAPSHOT.

device-2017-04-26-110030

@tobrun tobrun added this to the Release 5.1.0 milestone Apr 26, 2017
@tobrun tobrun self-assigned this Apr 26, 2017
@tobrun tobrun requested review from langsmith and cammace April 26, 2017 09:04
Copy link
Contributor

@cammace cammace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookin good to me :)

@langsmith
Copy link
Contributor

langsmith commented Apr 28, 2017

There are two tweaks I made. No problem if they shouldn't be included for whatever reason.

  1. I like the geographic diversity of the app. We already use Iceland in the "Animate marker position" example, so I chose Australia for this example.

  2. I added the camera target crosshair to show where/how the restriction is happening. I liked it in the test app and thought it'd be good to have in the demo app.

ezgif com-resize

@tobrun tobrun merged commit 2df0cb2 into master Apr 28, 2017
@tobrun tobrun deleted the tvn-add-restrict-camera branch April 28, 2017 11:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants