[@mantine/dates] DateInput: Separate clearable and allowDeselect logic #4527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4524.
The change is a bit larger than I intended but I believe it makes the
clearable
andallowDeselect
props more understandable:clearable
controls whether the DateInput can be cleared (via the text field or the date picker)allowDeselect
controls whether clicking on the existing date in the date picker clears the field (only applicable if clearable is set), defaults to true ifclearable
is setIf this is too much of a change, left me know and I'll revert it back to my original idea of just allowing
allowDeselect
to be manually set. The downside with this approach is that it can result in some weirdly inconsistent behaviour where the value can be cleared by clicking the date whenallowDeselect
is set andclearable
isn't set.