Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: Modernize and improve notification message component #325

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Breaking: Modernize and improve notification message component #325

wants to merge 6 commits into from

Commits on Jun 8, 2022

  1. Breaking: Update container component 

    - simplify component class
- move @z-index@ handling to CSS custom property

Replaces mansona#272
    @pichfl
    pichfl committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    652b973 View commit details
    Browse the repository at this point in the history

  2. Internal: Update prettier configuration

    @pichfl
    pichfl committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    303a9a1 View commit details
    Browse the repository at this point in the history

  3. Refactor: Move keyframes to container styles

    @pichfl
    pichfl committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    fdc72d3 View commit details
    Browse the repository at this point in the history

  4. Refactor: Handle notififaction htmlContent in backing class

    @pichfl
    pichfl committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    5d0b601 View commit details
    Browse the repository at this point in the history

  5. Redesign: Improved notification message (Potentially breaking) 

    * Better variables
* Slightly more readable colors
* Support `prefers-reduced-motion` and reduces motion in Ember tests by default
* Added proper ARIA role to notification
* Partially replaces mansona#250
    @pichfl
    pichfl committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    5a5edef View commit details
    Browse the repository at this point in the history

  6. Refactor: Use animationend event to remove notification 

    Much more stable than setTimeout and no longer blocks tests
    @pichfl
    pichfl committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    b8196dc View commit details
    Browse the repository at this point in the history