Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to put new notifications at top or bottom of stack (issue #223) #225

Closed
wants to merge 1 commit into from
Closed

Add ability to put new notifications at top or bottom of stack (issue #223) #225

wants to merge 1 commit into from

Conversation

MichaelPGriffin
Copy link

@MichaelPGriffin MichaelPGriffin commented Sep 1, 2018

This introduces functionality to display any new notification messages above or below the currently visible notifications. This behavior is driven from a stackNotifications property on the options object.

Fixes #223

@mansona
Copy link
Owner

mansona commented Nov 12, 2019

@MichaelPGriffin would it be ok for you to just override the display: flex and the flex-direction: column-reverse of the notification container? 🤔

This sort of thing has not been possible in the past because we are using CSS modules but #251 (comment) is due to change that. Let me know if this solves your problem 👍

Also I would be reluctant to add more config to this addon if we are able to solve the problem another way already 💪

@MichaelPGriffin
Copy link
Author

@mansona I hadn't considered a CSS-based approach, thanks for the idea. Offhand I'm not sure if that would change the actual ordering, or just the direction of the stacking.

For my purposes I ended up extending the notifications service and overriding the addNotification() method so the most recently added item would immediately get popped off the end and re-inserted at the beginning.

Also I'm sympathetic your concern about adding more config to this. I'm happy to close this issue as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to change the stacking direction
2 participants