Styled components #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudarshang
commented
Mar 22, 2018
| {tweets.map((t, i) => ( | ||
| <Tweet autoPlay={true} data={t} key={i} linkProps={linkProps} /> | ||
| ))} | ||
| const filteredTweets = tweets.filter(tweet => { |
There was a problem hiding this comment.
I filtered the tweets out here to ease the testing of the styled component migration of Video.js.
|
hey guys, thanks for the PR! Was out of town all weekend so havent gotten a chance to look at this but will provide some feedback soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to get feedback on the right way to migrate this project to styled-components. I have only migrated the Video component for now. @art1fa please let me know if this is how #25 should be handled.