Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rss feed for news #47

Merged
merged 2 commits into from
Nov 8, 2024
Merged

feat: add rss feed for news #47

merged 2 commits into from
Nov 8, 2024

Conversation

nurRiyad
Copy link
Contributor

@nurRiyad nurRiyad commented Nov 6, 2024

  • Generate rss feed for only news contents
  • Rss feed user /news/feed.xml
  • Use rss npm package with @types/rss for type support

@nurRiyad nurRiyad mentioned this pull request Nov 6, 2024
@romangg
Copy link
Member

romangg commented Nov 6, 2024

Generating the website with pnpm generate doesn't create the path.

@romangg
Copy link
Member

romangg commented Nov 6, 2024

You could use the rss package like here: https://github.com/subdiff/subdiff.org/blob/master/server/routes/blog/feed.xml.ts

@nurRiyad
Copy link
Contributor Author

nurRiyad commented Nov 7, 2024

Generating the website with pnpm generate doesn't create the path.

Sorry I forgot it's a generated page 🥲 . I will update as soon ass possible.

@romangg
Copy link
Member

romangg commented Nov 8, 2024

Thanks. Can the RSS feed go into manjaro.org/news/feed.xml.

@nurRiyad
Copy link
Contributor Author

nurRiyad commented Nov 8, 2024

Thanks. Can the RSS feed go into manjaro.org/news/feed.xml.

Sure updating

@nurRiyad
Copy link
Contributor Author

nurRiyad commented Nov 8, 2024

@romangg Review changes updated

@romangg
Copy link
Member

romangg commented Nov 8, 2024

Thank you! Working great. :)

@romangg romangg merged commit ef163e6 into manjaro:master Nov 8, 2024
5 checks passed
@romangg
Copy link
Member

romangg commented Nov 8, 2024

It would be cool to have a small button/icon in https://manjaro.org/news to link to the RSS feed. Something like

Screenshot_20241108_191043

at the bottom of https://subdiff.org/blog.

@nurRiyad
Copy link
Contributor Author

nurRiyad commented Nov 8, 2024

It would be cool to have a small button/icon in https://manjaro.org/news to link to the RSS feed. Something like

Screenshot_20241108_191043

at the bottom of https://subdiff.org/blog.

Ok updating.

@romangg
Copy link
Member

romangg commented Nov 8, 2024

Ah, I already merged this PR since the RSS feed itself can already go in. :)

Please open a new PR.

@nurRiyad nurRiyad deleted the riyad/rss branch November 8, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants