Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prerender issue for pagination component #43

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

nurRiyad
Copy link
Contributor

No description provided.

@nurRiyad nurRiyad mentioned this pull request Aug 13, 2024
@romangg
Copy link
Member

romangg commented Aug 14, 2024

It would be good if manjaro.org/news is page 1, and then for other pages it is manjaro.org/news/page/2 and so on. Also manjaro.org/news/page/1 should forward to manjaro.org/news.

I've done something similar at another site of mine. What do you think?

@nurRiyad
Copy link
Contributor Author

nurRiyad commented Aug 14, 2024

Yes, what you are suggesting is more convenient I think. Thanks for the review. Will update soon.

@nurRiyad nurRiyad force-pushed the riyad/pagination-fix branch 2 times, most recently from 54d2c7c to 1fc68ff Compare August 15, 2024 18:33
@nurRiyad
Copy link
Contributor Author

@romangg I have updated the pagination components.

@romangg
Copy link
Member

romangg commented Aug 16, 2024

Works great! I changed from news/pages/... to news/page/..., other than that let's merge it. Thanks @nurRiyad!

Closes #40

@romangg romangg merged commit 7823da8 into manjaro:master Aug 16, 2024
5 checks passed
@nurRiyad nurRiyad deleted the riyad/pagination-fix branch November 6, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants