Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Toggler Hydration Warning Handled #41

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

walleeva2018
Copy link
Contributor

This PR fixes the following Issue

What is Added

  • In Navbar View Theme Switcher which should be a client-side component was rendering as a Server side component. Fixed that

@romangg
Copy link
Member

romangg commented Aug 14, 2024

Alternative is to use v-show instead of v-if. I think I would prefer that as more can be statically generated this way. What do you think?

@walleeva2018
Copy link
Contributor Author

Alternative is to use v-show instead of v-if. I think I would prefer that as more can be statically generated this way. What do you think?

Yeah As Its navbar the load time will be faster. I will update that

@walleeva2018
Copy link
Contributor Author

@romangg Let me know if there is any problem

@romangg
Copy link
Member

romangg commented Aug 17, 2024

With the v-show the change to ClientOnly is not needed anymore. So this change needs to be removed from the branch/PR.

@romangg
Copy link
Member

romangg commented Aug 17, 2024

The cleanest solution is to use interactive rebase for that: https://git-rebase.io/

@walleeva2018 walleeva2018 force-pushed the zubair-client branch 2 times, most recently from dc5e14b to e24012a Compare August 18, 2024 05:47
@walleeva2018
Copy link
Contributor Author

With the v-show the change to ClientOnly is not needed anymore. So this change needs to be removed from the branch/PR.

Yeah My bad. Is it okay now?

@romangg
Copy link
Member

romangg commented Aug 28, 2024

Thanks for the update. The problem is that this revision still contains changes that are as far as I see not needed anymore.

@walleeva2018 walleeva2018 changed the title Theme Toggler Made Client-Only To Avoid Hydration Warnings Theme Toggler Hydration Warning Handled Oct 20, 2024
@romangg romangg merged commit 91bf1e4 into manjaro:master Oct 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants