Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix merges #3067

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions web/components/contract/contract-seo.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Contract, twombaContractPath } from 'common/contract'
import { Contract } from 'common/contract'
import { getSeoDescription, getContractOGProps } from 'common/contract-seo'
import { removeUndefinedProps } from 'common/util/object'
import { SEO } from '../SEO'
Expand All @@ -9,7 +9,7 @@ export function ContractSEO(props: {
points?: string
}) {
const { contract, points } = props
const { question } = contract
const { question, creatorUsername, slug } = contract

const seoDesc = getSeoDescription(contract)
const ogCardProps = removeUndefinedProps({
Expand All @@ -21,7 +21,7 @@ export function ContractSEO(props: {
<SEO
title={question}
description={seoDesc}
url={twombaContractPath(contract)}
url={`/${creatorUsername}/${slug}`}
ogProps={{ props: ogCardProps, endpoint: 'market' }}
/>
)
Expand Down
2 changes: 2 additions & 0 deletions web/components/contract/contract-tabs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,8 @@ export const CommentsTabContent = memo(function CommentsTabContent(props: {
useHashInUrl()
: // eslint-disable-next-line react-hooks/rules-of-hooks
useHashInUrlPageRouter('')

console.log('ID TO HIGHLIGHT', idToHighlight, appRouter)
useEffect(() => {
if (idToHighlight) {
const currentlyVisible = visibleCommentIds.includes(idToHighlight)
Expand Down
2 changes: 1 addition & 1 deletion web/pages/embed/[username]/[contractSlug].tsx
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export default function ContractEmbedPage(props: {
return (
<>
<NoSEO />
<ContractSEO contract={isCash ? liveCashContract! : contract} />
<ContractSEO contract={contract} />
<ContractSmolView
contract={isCash ? liveCashContract! : contract}
points={isCash ? cashPoints : points}
Expand Down
Loading