Ingawei/man 1823 shift market tiers down a level #2933

ingawei · 2024-10-08T00:07:48Z

Run by doing
SELECT * FROM update_contract_tiers_efficient(50, '1970-01-01 00:00:00'::timestamp);

Shifts tiers down a level and gets rid of the 'Basic' tier, for simplicity and so that Mana and Cash markets can have tiers on the same scale (100, 1k, 10k, 100k). SQL script backfills old markets so they are the correct downgraded tier.

linear · 2024-10-08T00:07:51Z

MAN-1823 shift market tiers down a level

vercel · 2024-10-08T00:07:53Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments

Name	Status	Preview	Updated (UTC)
dev	⬜️ Ignored (Inspect)	Visit Preview	Oct 9, 2024 9:41pm
docs	⬜️ Ignored (Inspect)	Visit Preview	Oct 9, 2024 9:41pm
prod	⬜️ Ignored (Inspect)	Visit Preview	Oct 9, 2024 9:41pm

…evel

IanPhilips

Thanks for working on unifying the tiers! It'll be great to eliminate the 'basic' tier which is very confusing atm.

I will say I have reservations about jumping to this cached tier approach before we've tried splitting out the totalLiquidity into its own column (which is as easy as adding another line to the contract_populate_cols function) and computing the tiers on the fly (this could be a line in the contracts table, like how description_fts is calculated). If we computed the tiers on the fly, this PR would be a lot simpler SQL-wise and avoid code duplication between typescript and sql. It'd also let us experiment with different liquidity requirements by changing a few numbers in typescript rather than having to edit typescript, the sql function, and our 150k contracts every time we changed something.

IanPhilips · 2024-10-10T15:57:01Z

backend/scripts/shift-tiers/backfill-tier-column.sql

+ WHERE c.id = tu.id
+ AND (c.tier IS DISTINCT FROM tu.new_tier OR c.tier IS NULL);
+
+ GET DIAGNOSTICS batch_updated = ROW_COUNT;


I've never used this type of batch editing before, so not sure how to evaluate it. I don't see a working script where you call this function so I can't evaluate how you'll run it, but I'd make sure to test this on dev and only test it on one contract to begin with. Also, once the script works on dev with a certain batch size, you'll still want to use a small batch on prod because of the higher activity.

I've only used typescript to grab contracts, then update them using ts logic. Is there a reason you wrote the script in sql instead of how our other scripts work?

IanPhilips · 2024-10-10T15:58:43Z

backend/scripts/backfill-tiers.ts

- !('marketTier' in ct.data()) &&
- 'totalLiquidity' in ct.data()
- )
+ return !('marketTier' in ct.data()) && 'totalLiquidity' in ct.data()


What is this file supposed to do? It uses firebase and won't change anything on our contracts

IanPhilips · 2024-10-10T15:59:14Z

backend/scripts/shift-tiers/backfill-tier-column.sql

+$$ language plpgsql;
+
+-- Commit the transaction to save the functions
+commit;


I don't think you need to commit a function

IanPhilips · 2024-10-10T16:12:57Z

backend/scripts/shift-tiers/get-tier-from-liquidity-function.sql

+ ELSE RETURN 'play';
+ END IF;
+END;
+$$ language plpgsql immutable;


This logic looks good, but ofc be sure to test it on dev first.

Thinking about this a bit more, I don't love how we'll have this logic duplicated in sql and ts, though. If we edit the FIXED_ANTE in ts, now we have to edit fixed_ante in sql and then also update every contract. That makes experimentation very slow. Have we tried putting totalLiquidity into its own native column and then computing the tiers on the fly? That would be much easier than having to precompute all of this.

IanPhilips · 2024-10-10T16:14:41Z

web/components/contract/contracts-table.tsx

+ </Tooltip>
+ </span>
+ )}
+ {!!contract.isSpicePayout && (


The spice is no longer!

ingawei · 2024-10-10T17:21:26Z

Thanks for working on unifying the tiers! It'll be great to eliminate the 'basic' tier which is very confusing atm.

I will say I have reservations about jumping to this cached tier approach before we've tried splitting out the totalLiquidity into its own column (which is as easy as adding another line to the contract_populate_cols function) and computing the tiers on the fly (this could be a line in the contracts table, like how description_fts is calculated). If we computed the tiers on the fly, this PR would be a lot simpler SQL-wise and avoid code duplication between typescript and sql. It'd also let us experiment with different liquidity requirements by changing a few numbers in typescript rather than having to edit typescript, the sql function, and our 150k contracts every time we changed something.

Yeah this was a big back and forth that happened when I first implemented tiers. The issue is it's not a hard number that if it's above and below it's a certain tier. For multi choice, a lower tier with 100 answers would cost the same as a binary with a higher tier. So it's not a simple SQL query if you're for example searching for a bunch of markets within a certain tier.

IanPhilips · 2024-10-10T17:27:18Z

Ah, so in the multichoice case where you can add answers, we could store the required ante, right? So we could still avoid having the hard-coded strings

ingawei · 2024-10-10T17:35:44Z

Ah, so in the multichoice case where you can add answers, we could store the required ante, right? So we could still avoid having the hard-coded strings

I see so you want to store total liquidity and base ante? So then when you filter by tier you just look for contracts in which total liquidity = ante * 10^tier?

IanPhilips · 2024-10-10T20:15:44Z

Ah, so in the multichoice case where you can add answers, we could store the required ante, right? So we could still avoid having the hard-coded strings

I see so you want to store total liquidity and base ante? So then when you filter by tier you just look for contracts in which total liquidity = ante * 10^tier?

I think we would just save base_ante for indie mc markets, ~~and it would work like sth if base_ante then base_ante > 10**ante_tier else total_liquidity>10**liquidity_tier,~~ wouldn't you just need the ante if the liquidity didn't matter, so why the equals sign?

IanPhilips · 2024-10-11T00:00:16Z

Oh I forgot to ask, where is get_tier_from_liquidity_efficient called after backfilling? You'll have to call it when adding or removing liquidity, right?

ingawei · 2024-10-11T00:26:48Z

It's here in add-liquidity.ts:

   await updateContract(tx, contractId, {
      subsidyPool: FieldVal.increment(subsidyAmount),
      totalLiquidity: FieldVal.increment(subsidyAmount),
      marketTier: getTierFromLiquidity(
        contract,
        contract.totalLiquidity + subsidyAmount
      ),
    })

I made the get_tier_from_liquidity_efficient function just for the purpose of backfilling which I'm now realizing was pretty dumb lol. It seemed simpler at the time to do it in SQL than to do it with ts, mainly cause I couldn't find any example scripts backfilling to supabase

ingawei added 4 commits October 3, 2024 15:04

shift down tiers

2ba87f2

add script that is not working

dad1878

add sql files

bf89bf8

merged

7f30ef8

ingawei added 2 commits October 7, 2024 17:08

Merge branch 'main' into ingawei/man-1823-shift-market-tiers-down-a-l…

326f406

…evel

tier column

c160b22

vercel bot deployed to Preview – dev October 8, 2024 01:08 View deployment

vercel bot deployed to Preview – prod October 8, 2024 01:08 View deployment

merge conflicts

43bd7bc

vercel bot had a problem deploying to Preview – dev October 9, 2024 21:26 Failure

vercel bot had a problem deploying to Preview – prod October 9, 2024 21:26 Failure

ingawei added 3 commits October 9, 2024 14:32

backfill tiers

d591795

no coin or tier column

0bbfc87

backfill tier undo

a7fbf38

ingawei requested a review from IanPhilips October 9, 2024 21:38

IanPhilips reviewed Oct 10, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ingawei/man 1823 shift market tiers down a level #2933

Ingawei/man 1823 shift market tiers down a level #2933

ingawei commented Oct 8, 2024 •

edited

Loading

linear bot commented Oct 8, 2024

vercel bot commented Oct 8, 2024 •

edited

Loading

IanPhilips left a comment

IanPhilips Oct 10, 2024

IanPhilips Oct 10, 2024

IanPhilips Oct 10, 2024

IanPhilips Oct 10, 2024

IanPhilips Oct 10, 2024

ingawei commented Oct 10, 2024

IanPhilips commented Oct 10, 2024

ingawei commented Oct 10, 2024

IanPhilips commented Oct 10, 2024 •

edited

Loading

IanPhilips commented Oct 11, 2024

ingawei commented Oct 11, 2024

Ingawei/man 1823 shift market tiers down a level #2933

Are you sure you want to change the base?

Ingawei/man 1823 shift market tiers down a level #2933

Conversation

ingawei commented Oct 8, 2024 • edited Loading

linear bot commented Oct 8, 2024

vercel bot commented Oct 8, 2024 • edited Loading

IanPhilips left a comment

Choose a reason for hiding this comment

IanPhilips Oct 10, 2024

Choose a reason for hiding this comment

IanPhilips Oct 10, 2024

Choose a reason for hiding this comment

IanPhilips Oct 10, 2024

Choose a reason for hiding this comment

IanPhilips Oct 10, 2024

Choose a reason for hiding this comment

IanPhilips Oct 10, 2024

Choose a reason for hiding this comment

ingawei commented Oct 10, 2024

IanPhilips commented Oct 10, 2024

ingawei commented Oct 10, 2024

IanPhilips commented Oct 10, 2024 • edited Loading

IanPhilips commented Oct 11, 2024

ingawei commented Oct 11, 2024

ingawei commented Oct 8, 2024 •

edited

Loading

vercel bot commented Oct 8, 2024 •

edited

Loading

IanPhilips commented Oct 10, 2024 •

edited

Loading