-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search users by username first #2764
base: main
Are you sure you want to change the base?
Search users by username first #2764
Conversation
I ran into an issue where users with short usernames sometimes don't get returned from the search-users API in the first few rows. This is a problem, as the @ dialog in the comment box uses search-users with a limit of 6, so there is sometimes no way to mention a user, even with an exact username match. This change adds a query to search for an exact match username and present that as the first result, if present.
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
@benmanns is attempting to deploy a commit to the Manifold Markets Team on Vercel. A member of the Team first needs to authorize it. |
Hey thanks for submitting this! Could you share a username this works for that our current search doesn't work for? |
I was trying to tag Vo username @d on this market. |
It's a bit more complicated because if I type zvi it should match ZviMowshowitz and not 'zvi', so not sure how to handle that yet |
I support the exact match use case, even with the downside that it might not surface the most popular person. One solution would be to put the exact match after the first other result! |
I like the suggestion of making it auto-mention the exact match if no other is selected! |
I ran into an issue where users with short usernames sometimes don't get returned from the search-users API in the first few rows. This is a problem, as the @ dialog in the comment box uses search-users with a limit of 6, so there is sometimes no way to mention a user, even with an exact username match. This change adds a query to search for an exact match username and present that as the first result, if present.
Note: I've not gotten manifold running locally, so I haven't been able to test this.