-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N/A all contracts on independent multi #2676
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Approved, pending a few comments.
const onCancelAll = async () => { | ||
setIsSubmitting(true) | ||
try { | ||
for (const answer of answers) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ask chat gpt to turn this for loop into a Promise.all. This will make it only a bit faster because the server will still resolve each answer sequentially.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't that hit by-IP rate limit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question! I don't know our exact limits, but I think a hundred requests in a short period would be ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this (see recent commit), but I think it has introduced an API error.
APIError: High volume of requests. Please try again later.
It managed to get through about 3-4 N/As each time before it then failed to resolve the rest.
No description provided.