Primitive port and node construction #45

mtrberzi · 2014-12-07T21:47:59Z

I would like to submit this pull request for review, knowing that I am not done with it yet. There is a lot of code here, but finishing all of the features I have marked as TODO in the code would result in a PR of several thousand lines, and this is bad enough already.

Yes, this finally gets rid of the old digital circuit primitive definitions. Those are going to be gone permanently after this, because we can now define port types and node types in the frontend language.
This also removes all of the old "functionality" of ExpressionGraph, which made horrible assumptions about the structure of the schematic that was being compiled and wouldn't work for anything except digital circuits.
TypeChecker is completely gone. All typing can be done dynamically through the expression graph, which has all the benefits of a static system while providing dynamic typing only where it is actually used.
Test coverage is down quite a bit, but I plan to add some test cases to this branch after it is reviewed and hopefully get the coverage even higher than it is now.
There are many TODOs hanging around in the code. Some of them are easy enough to resolve before this is merged; some of them are large enough to merit opening a separate issue.

Conflicts: build.gradle src/main/java/org/manifold/compiler/front/ExpressionGraph.java src/main/java/org/manifold/compiler/front/FrontendValueVisitor.java

...IT BEGINS.

(removes most of ExpressionGraph, so WIP.)

tuple type value expr (WIP)

lucaswoj · 2015-01-07T22:48:38Z

src/main/java/org/manifold/compiler/front/PrimitivePortDefinitionExpression.java

+
+public class PrimitivePortDefinitionExpression extends Expression {
+
+  // TODO(murphy) figure out where the name of the port type value comes from


Leaving it since this is going away soon

lucaswoj · 2015-01-07T22:57:09Z

Done my first review. Sorry about the zoo.

maxqchen · 2015-01-10T17:51:44Z

src/main/java/org/manifold/compiler/front/ExpressionGraphBuilder.java

+
+public class ExpressionGraphBuilder implements ExpressionVisitor {
+
+  private static Logger log = LogManager.getLogger("ExpressionGraph");


nit: ExpressionGraphBuilder.class?

maxqchen · 2015-01-10T18:37:45Z

Logic looks good (AFAIK anyways, still a bit fuzzy on the whole thing), just a few minor nit picky things 🚲.

mtrberzi · 2015-01-11T19:11:19Z

Fantastic first round of review, everyone! Thanks again. New commits are available.

coveralls · 2015-01-11T19:13:24Z

Coverage decreased (-20.15%) when pulling 8786e67 on mtrberzi:primitive-definitions into 3d9b44a on manifold-lang:master.

Primitive port and node construction

mtrberzi added 30 commits November 13, 2014 12:17

primitive port type value (WIP)

80c7484

Merge branch 'expression-graph-visualization' into primitive-definitions

f8109a8

primitive port definitions

222f3d2

Merge branch 'expression-rework' into primitive-definitions

2150405

Conflicts: build.gradle src/main/java/org/manifold/compiler/front/ExpressionGraph.java src/main/java/org/manifold/compiler/front/FrontendValueVisitor.java

fixes to work with type-checker; primitive port is now an Expression

aa421b4

Merge branch 'master' into primitive-definitions

e895a55

add writeToDOTFile()

5042927

alter debugging code to use logging instead of console print

c111d73

the type of a primitive port definition is Type

6a77cc5

remove mocked-up digital circuit primitive definitions

f0fe6fa

...IT BEGINS.

add no-args getValue(), since we don't use the Scope anyway

435b107

expression graph building from dedicated class

801d659

(removes most of ExpressionGraph, so WIP.)

add primitive node expression and vertex

1231835

include antlr4 runtime in generated JAR

e9a5622

modify functionTypeValue grammar rule; add function type value expr,

c097d81

tuple type value expr (WIP)

add expression vertices for function type value, tuple type value

4b02f9b

fix assignment of lastVertex when building function type value

7cb0bfb

set lastVertex correctly when visiting tuple type value

acad5dc

annotate expression edges with meaningful names

a77e667

remove obsolete vertex classes; add evaluation methods to expression vs

b9c0d8f

primitive port elaboration

e521670

ExpressionVertex knows about parent ExpressionGraph

03ec032

substitute constant values for reserved identifiers such as Bool

d93c222

remove useless expression argument in constructors

b7e510f

test primitive port vertex construction and elaboration

e01b933

remove static typechecker; we never needed it

733b68d

remove useless expression argument

c1b93cb

primitive node elaboration (WIP)

bb7bb12

working node type construction

a1e326a

remove unused function

65efbb1

lucaswoj reviewed Jan 7, 2015
View reviewed changes

maxqchen reviewed Jan 10, 2015
View reviewed changes

mtrberzi added 5 commits January 11, 2015 13:39

refactor: createVariableVertex/addNonVariableVertex -> addVertex

6ff7c2d

remove TODOs

81321f0

remove PrimitiveFunctionValue

171db62

remove TODOs

76fc1c3

nits

8786e67

mtrberzi added a commit that referenced this pull request Jan 20, 2015

Merge pull request #45 from mtrberzi/primitive-definitions

1501190

Primitive port and node construction

mtrberzi merged commit 1501190 into manifold-lang:master Jan 20, 2015

mtrberzi deleted the primitive-definitions branch January 20, 2015 01:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Primitive port and node construction #45

Primitive port and node construction #45

mtrberzi commented Dec 7, 2014

lucaswoj Jan 7, 2015

mtrberzi Jan 11, 2015

lucaswoj commented Jan 7, 2015

maxqchen Jan 10, 2015

maxqchen commented Jan 10, 2015

mtrberzi commented Jan 11, 2015

coveralls commented Jan 11, 2015


		public class PrimitivePortDefinitionExpression extends Expression {

		// TODO(murphy) figure out where the name of the port type value comes from


		public class ExpressionGraphBuilder implements ExpressionVisitor {

		private static Logger log = LogManager.getLogger("ExpressionGraph");

Primitive port and node construction #45

Primitive port and node construction #45

Conversation

mtrberzi commented Dec 7, 2014

lucaswoj Jan 7, 2015

Choose a reason for hiding this comment

mtrberzi Jan 11, 2015

Choose a reason for hiding this comment

lucaswoj commented Jan 7, 2015

maxqchen Jan 10, 2015

Choose a reason for hiding this comment

maxqchen commented Jan 10, 2015

mtrberzi commented Jan 11, 2015

coveralls commented Jan 11, 2015