Replaced 'int' type with 'intptr_t' type in pointer arithmetic for compiling without -fpermisive + revisions by McNeight #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added vim related entries to .gitignore from https://github.com/github/gitignore/blob/master/Global/Vim.gitignore Verfied code against Arduino 1.6.1 running on Arduino Leonardo
This causes a compiler warning.
Remove semicolon from #include "MemoryFree.h";
…mpiling without -fpermisive
|
oops wrong repo sorry :( EDIT: I'll leave it here since it seems to contain usefull edits. |
s-t-a-n
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler yabs about losing precision:
~/Arduino/libraries/MemoryFree/src/MemoryFree.cpp:44:7: error: cast from 'void*' to 'int' loses precision [-fpermissive]
Using intptr_t type (as per C99 I believe) is recommended because it guarantees to hold the size of a pointer.
The Arduino IDE compiles with -fpermisive by default, but continuous integration frameworks like Arduino-CI and Cmake/Makefile type compilation does not.
Tested in Arduino-CI and on an Arduino Mega2560.
EDIT: I accidentally opened a pull request for this repo whilst I meant to open it for McNeights. Close it if you like. Pull it if you want.