Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Linux Install Script #203

Closed

Conversation

Pysis868
Copy link
Contributor

@Pysis868 Pysis868 commented Aug 1, 2024

Added Fedora 40 support.
Included upgrading ACE requirement to latest stable 7.1.0.
6.3.3 had a stropts compile error.
Added dialog app fzf.
Added settings and enabled control from environment.
Propagated database selection control.
Updated and organized, paths and database name(s).
Organized code.


This change is Reviewable

Added Fedora 40 support.
Included upgrading ACE requirement to latest stable 7.1.0.
6.3.3 had a stropts compile error.
Added dialog app `fzf`.
Added settings and enabled control from environment.
Propagated database selection control.
Updated and organized, paths and database name(s).
Organized code.
@AppVeyorBot
Copy link

Make choice value shell error code response less error prone with more explicit block control flow with additional keywords.
Add shellcheck exception as that situation was intentional, and even performed successfully in older script versions, as assumed.
@AppVeyorBot
Copy link

Use `installer` variable as I think would be intended to easily utilize the benefit of keeping the other related code portions.
@AppVeyorBot
Copy link

Propagate shellcheck exception to the relevant original code as well.
@AppVeyorBot
Copy link

Copy link
Member

@billy1arm billy1arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Pysis868)

Copy link
Member

@billy1arm billy1arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pysis868 can you revert the changes in mangosd.conf.dist.in

The build system populates this and it should not be set to a value

@Pysis868
Copy link
Contributor Author

Confirming *.in file removed, and see no others there.
If problem is recreated at all, I suggest gitignore, or may be better, moving actively used file out of source tree, to the build one.

@AppVeyorBot
Copy link

Per AppVeyor build failure, seems that file is required by the build system, not produced by from it.
@Pysis868
Copy link
Contributor Author

Pysis868 commented Aug 28, 2024

Relevant Build Messages:

CMake Error: File C:/mzero/server_sources/src/mangosd/mangosd.conf.dist.in does not exist.
CMake Error at src/mangosd/CMakeLists.txt:91 (configure_file):
  configure_file Problem configuring file
===================================================
Mangos revision       : 44c6c38c1e80 2024-08-28 19:40:21 +0000 (HEAD branch)
Build type            : Release
Install server(s) to  : C:/mzero/output/server_debugx64
Install configs to    : .
Detailed Information
+-- operating system   : Windows-10.0.17763
+-- cmake version     : 3.29.3
Build main server     : Yes (default)
+-- with Eluna script engine
+-- with SD3 script engine
+-- with PlayerBots
Build login server    : Yes (default)
Support for SOAP      : Yes
Build tools           : Yes (default)
===================================================
-- Configuring incomplete, errors occurred!
Command exited with code 1

@AppVeyorBot
Copy link

for incremental build capability from the install script.
@AppVeyorBot
Copy link

@billy1arm
Copy link
Member

Implemented in:
5b4c8c0

@billy1arm billy1arm closed this Aug 29, 2024
@Pysis868 Pysis868 deleted the feature/update-linux-install-script branch August 29, 2024 15:45
@Pysis868 Pysis868 restored the feature/update-linux-install-script branch August 29, 2024 16:02
@Pysis868 Pysis868 deleted the feature/update-linux-install-script branch August 29, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants