-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Linux Install Script #203
Improve Linux Install Script #203
Conversation
Added Fedora 40 support. Included upgrading ACE requirement to latest stable 7.1.0. 6.3.3 had a stropts compile error. Added dialog app `fzf`. Added settings and enabled control from environment. Propagated database selection control. Updated and organized, paths and database name(s). Organized code.
Make choice value shell error code response less error prone with more explicit block control flow with additional keywords. Add shellcheck exception as that situation was intentional, and even performed successfully in older script versions, as assumed.
Use `installer` variable as I think would be intended to easily utilize the benefit of keeping the other related code portions.
Propagate shellcheck exception to the relevant original code as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Pysis868)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pysis868 can you revert the changes in mangosd.conf.dist.in
The build system populates this and it should not be set to a value
Confirming |
Per AppVeyor build failure, seems that file is required by the build system, not produced by from it.
Relevant Build Messages:
|
for incremental build capability from the install script.
Implemented in: |
Added Fedora 40 support.
Included upgrading ACE requirement to latest stable 7.1.0.
6.3.3 had a stropts compile error.
Added dialog app
fzf
.Added settings and enabled control from environment.
Propagated database selection control.
Updated and organized, paths and database name(s).
Organized code.
This change is