Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refer-A-Friend System prepared for s1980 adopted from archiv s1699 #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refer-A-Friend System prepared for s1980 adopted from archiv s1699 #13

wants to merge 3 commits into from

Conversation

Hikarii
Copy link
Contributor

@Hikarii Hikarii commented Apr 15, 2013

This is a (nearly) 1:1 copy of the Refer-A-Friend System of the archiv repository at https://github.com/mangos-one/server-old

Taken from

Signed-off-by: Salja [email protected]

Hikarii
Hikarii reviewed Apr 18, 2013
View reviewed changes
src/game/World.cpp
setConfigMinMax(CONFIG_UINT32_RAF_MAXREFERALS, "RAF.MaxReferals", 5, 0, 15);
setConfigMinMax(CONFIG_UINT32_RAF_MAXREFERERS, "RAF.MaxReferers", 5, 0, 15);
setConfig(CONFIG_FLOAT_RATE_RAF_XP, "Rate.RAF.XP", 3.0f);
setConfig(CONFIG_FLOAT_RATE_RAF_LEVELPERLEVEL, "Rate.RAF.XP", 0.5f);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Should be setConfig(CONFIG_FLOAT_RATE_RAF_LEVELPERLEVEL, "Rate.RAF.LevelPerLevel", 0.5f);

@Salja
Copy link
Contributor

Salja commented Apr 18, 2013

some more need fixed the patch make a traget bug i think the patch need a full rewirte

@Hikarii
Copy link
Contributor Author

Hikarii commented Apr 18, 2013

You talk about the target bug by summoning a friend by using the corresponding context menu option, while targeting another player, NPC or creature, which leads to fail the spell, right?

@Salja
Copy link
Contributor

Salja commented Apr 18, 2013

yes thats i mean =) and i think some we can make better in the code some more clean etc

@Hikarii
Copy link
Contributor Author

Hikarii commented Apr 19, 2013

I've some suggestions for the new system. I've read blizzards article about refer a friend and I've found that there are more conditions which are missing in the current system.

  • CONFIG_UINT32_RAF_MAXGRANTLEVEL should also affect CONFIG_FLOAT_RATE_RAF_XP. Above the given level there will be no longer bonus xp.
  • CONFIG_UINT32_RAF_MAXGRANTLEVEL should also affect the summonig spell. players with level equal or lower than the value can be summoned. Above not.
  • If the level difference between the players ar bigger than 3 (former it was 4, which includes tbc), then only the lower one gain bonus xp the other gain normal xp.
  • You can only grant a level to a character which is below your own level.
  • The bonus xp of the refer a friend system should be shown in the combat log (like the rested bonus).

These informations are from blizzards system for Mist of Pandaria. Whether this matchs the situation back in The Burning Crusade... I don't know.

Fix Error with Travis
fe70619 
- Revert my poor implementation of the friend list function to its initial state of the archive.
  Travis error was caused because #include<iterater> wasn't included anywhere. But I think there is a better solution for this function as using std::ostream_iterator<T> like I did.

- Fix typo while loading RAF configuration.
@billy1arm
Copy link
Contributor

@Hikarii - Do you think you can get this fixed up so that we can attempt testing on it ?

@Hikarii
Copy link
Contributor Author

Hikarii commented Apr 1, 2014

@billy1arm I don't know. I'll try it. What do you want to be fixed? The suggestions I made above?

@billy1arm
Copy link
Contributor

@Hikarii yes please

@Hikarii
Copy link
Contributor Author

Hikarii commented Oct 8, 2014

@billy1arm Currently the RAF system is in its original state, how it was back in rel 12.1. Hence untested for Rel 19!
I haven't pushed the fix for reputation gain yet. I can do that yet, if you want.
Unfortunately I haven't made any progress in the context menu targeting issue mentioned above.

@billy1arm
Copy link
Contributor

@Hikarii - could you push the 'reputation gain fix' ?

@Hikarii
Fix reputation gain in RAF system
4ab8f99 
The bonus on reputation, granted by killing creatures and quest rewards, is 10%, not 300%.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hikarii @Salja @billy1arm