Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use defaultdicts for BaseHubConnection handlers instead of lists #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sam-mosleh
Copy link

This PR uses defaultdicts for handlers in BaseHubConnection. Using lists can cause major performance issues.

@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #50 (44c5c04) into master (91a94ee) will increase coverage by 0.57%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   94.45%   95.03%   +0.57%     
==========================================
  Files          32       32              
  Lines        1227     1228       +1     
==========================================
+ Hits         1159     1167       +8     
+ Misses         68       61       -7     
Impacted Files Coverage Δ
signalrcore/hub/base_hub_connection.py 82.58% <84.61%> (+1.58%) ⬆️
signalrcore/protocol/base_hub_protocol.py 91.66% <0.00%> (+4.16%) ⬆️
signalrcore/messages/close_message.py 100.00% <0.00%> (+40.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91a94ee...44c5c04. Read the comment docs.

Base automatically changed from master to main March 10, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant