-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouples Filesystem implementation #48
Decouples Filesystem implementation #48
Conversation
aec24f6
to
8a4a0e0
Compare
@puffyCid The tests included in the crate are passing - There are a couple of things that I'm not sure about right now:
|
9df54d3
to
be73d05
Compare
@dgmcdona This is looking good. Few thought so far:
For tests, I uploaded test_data.zip to the releases page. I will open PR that will commit the |
690bf72
to
7e2f60f
Compare
This refactors the way that the parser handles paths in general, removing the filesystem-specific implementation details from the parsing fuctions, and providing a new interface centered around providing the correct readers through the `FileProvider` trait. Default implementations for live-system and logarchive formats are provided, as are utilities for categorizing files by path. This requird updates throughout the repo's tests, and if merged, will require updates to the larger tests that are currently shipping in the test archive.
Updates the `FileProvider` trait to return iterators of boxed `SourceFile` trait objects. This preserves source file path information for use by the parsers.
7e2f60f
to
ae63ec0
Compare
Not sure why this increased, but I'm assuming that its related to path enumeration and is a positive change.
08da0e7
to
1b309b2
Compare
Another test value that needed a bump after incorporating changes.
Increased two check values in separate tests - more records were being returned, presumably because of the inclusion of the |
This is looking really good, im really happy the tests all pass. I tried out the example files, looks like some minor issues may slipped through.
|
@dgmcdona if u have time and get chance to at least fixup the unifiedlog_iterator example. I would be happy to merge. |
Thanks, I'll push the remaining fixes shortly |
Also fixes bugs from review
This removes the other examples since all of the functionality is now contained by the unifiedlog_iterator example. Also renames unifiedlog_iterator to unifiedlog_parser
There was so much functionality shared between the examples that I just bundled it all together with a |
looks good thanks! |
This refactors the way that the parser handles paths in general, removing the filesystem-specific implementation details from the parsing fuctions, and providing a new interface centered around providing the correct readers through the
FileProvider
trait. Default implementations for live-system and logarchive formats are provided, as are utilities for categorizing files by path. This requird updates throughout the repo's tests, and if merged, will require updates to the larger tests that are currently shipping in the test archive.