Firehose Log: Performance + Refactor #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces `Vec` uses with static arrays, declares variables as `const`, and renames those variables to all caps.
This removes unneeded calls to `take(size_of::<>())`.
This reduces the overall number of allocations by removing two vecs of intermediate string allocations, and instead stores the raw numbers, waiting to render them into strings until the final output vec is constructed.
|
Hi @dgmcdona, I see you also have refactor ambitions on this lib. If you want you can pick some from this abandonned PR where I have been "a little too much" : https://github.com/mandiant/macos-UnifiedLogs/pull/22/files Glad to have another |
Thanks, and likewise! I'll check out your changes and see if there is anything I should pull in with these. |
|
looks good thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some refactoring in
firehose_log.rsthat should provide some performance gains by eliminating allocation of severalVecs throughout the file. It also simplifies somenomparsing, where data was first being extracted withtakebefore being handed off to the integer parsers.