Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR change the
parse_svcb_ip
function impl.It's a little more complicated (sorry for that), but reduce the number of allocations :
n4 : number of ipv4 addresses
n6 : number of ipv6 addresses
Before :
2 + n4 + n6 + 2 + 1
(2 vecs + to_string for IPs + 2 joins + format!)After (best case) :
2 + 1
(2 string buffers + format! in the end)In the worst case, if there are many many ip addresses, String growth will reallocate the buffers, so it might be not that interesting.
What is the expected/usual number of ip addresses here ?