Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test / test_data alignements #28

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Conversation

jrouaix
Copy link
Contributor

@jrouaix jrouaix commented Nov 14, 2024

Hello,
I just added some changes to have better DX.
I don't really know why the test_data was misaligned with actual tests.

…repo.

=> really helpful when having this as a git submodule of another workspace ;-)
- test values changed according to the downloadable test data
@jrouaix
Copy link
Contributor Author

jrouaix commented Nov 14, 2024

well, it did not work.
@puffyCid are the test data distributed in the release aligned with the current code/branch ?
would you have another way to distribute test data that be updated more easily ?

@jrouaix
Copy link
Contributor Author

jrouaix commented Nov 14, 2024

According to the .github/workflows/pullrequest.yml file, I download the exact same file as the GH actions runner.
So why I end up with other values on my machine ? (Ubuntu 22.04)

image

@jrouaix
Copy link
Contributor Author

jrouaix commented Nov 14, 2024

Ok, I know, fs::read_dir() doesn't return the files in the same order on distinct targets ...
@puffyCid, do we order files by name before the iteration ?
(will try this way on the next commit)

@puffyCid
Copy link
Collaborator

Ok, I know, fs::read_dir() doesn't return the files in the same order on distinct targets ... @puffyCid, do we order files by name before the iteration ? (will try this way on the next commit)

Ah i did not realize read_dir() ordering is dependent on the filesystem
I left a few comments that i think could help improve the tests
let me know your thoughts @jrouaix

@jrouaix
Copy link
Contributor Author

jrouaix commented Nov 15, 2024

I left a few comments that i think could help improve the tests

I don't see your comments ...

src/parser.rs Outdated Show resolved Hide resolved
src/parser.rs Outdated Show resolved Hide resolved
src/parser.rs Outdated Show resolved Hide resolved
src/parser.rs Outdated Show resolved Hide resolved
@puffyCid puffyCid merged commit 20579ec into mandiant:main Nov 20, 2024
4 checks passed
@jrouaix jrouaix deleted the test_data_debug branch November 21, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants