Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loader: fix unhandled name error #2411

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

williballenthin
Copy link
Collaborator

it was possible that loading the workspace could raise an exception that would get swallowed, but vw wasn't bound. this ensures the exception is always raised.

the exception that i saw get swallowed was "unsupported architecture" like 32-bit armv8.

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

@williballenthin williballenthin added the bug Something isn't working label Sep 30, 2024
Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@williballenthin williballenthin merged commit ab43c8c into master Sep 30, 2024
24 checks passed
@williballenthin williballenthin deleted the williballenthin-patch-1 branch September 30, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants