Add pit for join queries (opensearch-project#2703)

* Add search after for join Signed-off-by: Rupal Mahajan <[email protected]> * Enable search after by default Signed-off-by: Rupal Mahajan <[email protected]> * Add pit Signed-off-by: Rupal Mahajan <[email protected]> * nit Signed-off-by: Rupal Mahajan <[email protected]> * Fix tests Signed-off-by: Rupal Mahajan <[email protected]> * ignore joinWithGeoIntersectNL Signed-off-by: Rupal Mahajan <[email protected]> * Rerun CI with scroll Signed-off-by: Rupal Mahajan <[email protected]> * Remove unused code and retrigger CI with search_after true Signed-off-by: Rupal Mahajan <[email protected]> * Address comments Signed-off-by: Rupal Mahajan <[email protected]> * Remove unused code change Signed-off-by: Rupal Mahajan <[email protected]> * Update pit keep alive time with SQL_CURSOR_KEEP_ALIVE Signed-off-by: Rupal Mahajan <[email protected]> * Fix scroll condition Signed-off-by: Rupal Mahajan <[email protected]> * nit Signed-off-by: Rupal Mahajan <[email protected]> * Add pit before query execution Signed-off-by: Rupal Mahajan <[email protected]> * nit Signed-off-by: Rupal Mahajan <[email protected]> * Move pit from join request builder to executor Signed-off-by: Rupal Mahajan <[email protected]> * Remove unused methods Signed-off-by: Rupal Mahajan <[email protected]> * Add pit in parent class's run() Signed-off-by: Rupal Mahajan <[email protected]> * Add comment for fetching subsequent result in NestedLoopsElasticExecutor Signed-off-by: Rupal Mahajan <[email protected]> * Update comment Signed-off-by: Rupal Mahajan <[email protected]> * Add javadoc for pit handler Signed-off-by: Rupal Mahajan <[email protected]> * Add pit interface Signed-off-by: Rupal Mahajan <[email protected]> * Add pit handler unit test Signed-off-by: Rupal Mahajan <[email protected]> * Fix failed unit test CI Signed-off-by: Rupal Mahajan <[email protected]> * Fix spotless error Signed-off-by: Rupal Mahajan <[email protected]> * Rename pit class and add logs Signed-off-by: Rupal Mahajan <[email protected]> * Fix pit delete unit test Signed-off-by: Rupal Mahajan <[email protected]> --------- Signed-off-by: Rupal Mahajan <[email protected]>
manasvinibs · Aug 15, 2024 · d8330af · d8330af
1 parent 7815c96
commit d8330af
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/legacy/src/main/java/org/opensearch/sql/legacy/executor/join/ElasticJoinExecutor.java b/legacy/src/main/java/org/opensearch/sql/legacy/executor/join/ElasticJoinExecutor.java
@@ -31,6 +31,7 @@
 import org.opensearch.sql.legacy.esdomain.LocalClusterState;
 import org.opensearch.sql.legacy.exception.SqlParseException;
 import org.opensearch.sql.legacy.executor.ElasticHitsExecutor;
+import org.opensearch.sql.legacy.pit.PointInTimeHandler;
 import org.opensearch.sql.legacy.pit.PointInTimeHandlerImpl;
 import org.opensearch.sql.legacy.query.SqlElasticRequestBuilder;
 import org.opensearch.sql.legacy.query.join.HashJoinElasticRequestBuilder;
@@ -47,7 +48,9 @@ public abstract class ElasticJoinExecutor extends ElasticHitsExecutor {
   protected final int MAX_RESULTS_ON_ONE_FETCH = 10000;
   private Set<String> aliasesOnReturn;
   private boolean allFieldsReturn;
+  protected Client client;
   protected String[] indices;
+  protected PointInTimeHandler pit;
 
   protected ElasticJoinExecutor(Client client, JoinRequestBuilder requestBuilder) {
     metaResults = new MetaSearchResult();