Skip to content

Commit

Permalink
chore: remove unused argument from write_vk command (noir-lang#3183)
Browse files Browse the repository at this point in the history
  • Loading branch information
TomAFrench authored Oct 17, 2023
1 parent 6b87582 commit 92b333f
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 14 deletions.
1 change: 0 additions & 1 deletion tooling/backend_interface/src/cli/contract.rs
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ fn contract_command() -> Result<(), BackendError> {
let write_vk_command = super::WriteVkCommand {
bytecode_path,
vk_path_output: vk_path.clone(),
is_recursive: false,
crs_path: crs_path.clone(),
};
write_vk_command.run(backend.binary_path())?;
Expand Down
1 change: 0 additions & 1 deletion tooling/backend_interface/src/cli/verify.rs
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ fn verify_command() -> Result<(), BackendError> {
let write_vk_command = WriteVkCommand {
bytecode_path: bytecode_path.clone(),
crs_path: crs_path.clone(),
is_recursive: false,
vk_path_output: vk_path_output.clone(),
};

Expand Down
8 changes: 1 addition & 7 deletions tooling/backend_interface/src/cli/write_vk.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ use crate::BackendError;
/// to write a verification key to a file
pub(crate) struct WriteVkCommand {
pub(crate) crs_path: PathBuf,
pub(crate) is_recursive: bool,
pub(crate) bytecode_path: PathBuf,
pub(crate) vk_path_output: PathBuf,
}
Expand All @@ -25,10 +24,6 @@ impl WriteVkCommand {
.arg("-o")
.arg(self.vk_path_output);

if self.is_recursive {
command.arg("-r");
}

let output = command.output()?;
if output.status.success() {
Ok(())
Expand All @@ -53,8 +48,7 @@ fn write_vk_command() -> Result<(), BackendError> {

std::fs::File::create(&bytecode_path).expect("file should be created");

let write_vk_command =
WriteVkCommand { bytecode_path, crs_path, is_recursive: false, vk_path_output };
let write_vk_command = WriteVkCommand { bytecode_path, crs_path, vk_path_output };

write_vk_command.run(backend.binary_path())?;
drop(temp_directory);
Expand Down
1 change: 0 additions & 1 deletion tooling/backend_interface/src/proof_system.rs
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ impl Backend {

WriteVkCommand {
crs_path: self.crs_directory(),
is_recursive,
bytecode_path,
vk_path_output: vk_path.clone(),
}
Expand Down
1 change: 0 additions & 1 deletion tooling/backend_interface/src/smart_contract.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ impl Backend {

WriteVkCommand {
crs_path: self.crs_directory(),
is_recursive: false,
bytecode_path,
vk_path_output: vk_path.clone(),
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ pub(crate) struct WriteVkCommand {
#[clap(short = 'b')]
pub(crate) bytecode_path: PathBuf,

#[clap(short = 'r')]
pub(crate) is_recursive: bool,

#[clap(short = 'o')]
pub(crate) vk_path: PathBuf,
}
Expand Down

0 comments on commit 92b333f

Please sign in to comment.