Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr 12 #13

Merged
merged 5 commits into from
May 28, 2024
Merged

Pr 12 #13

merged 5 commits into from
May 28, 2024

Commits on May 24, 2024

  1. If not set, don't set a value for user_id 

    Better follow the guidance of [Amplitude](https://help.amplitude.com/hc/en-us/articles/115003135607-Track-unique-users).

If you're working in an unauthenticated environment, you should not send a user id b/c it can conflict with added user ids + lead to join issues later.

This'd also require updating the text in the dashboard which currently says one will be set if not.
    @kodster28
    kodster28 authored May 24, 2024
    Configuration menu
    Copy the full SHA
    3afc882 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. run client.set if payload includes user_id and fix bug in getEventData

    @ad-astra-via
    ad-astra-via committed May 27, 2024
    Configuration menu
    Copy the full SHA
    732e0ea View commit details
    Browse the repository at this point in the history

  2. prettier cleanup

    @ad-astra-via
    ad-astra-via committed May 27, 2024
    Configuration menu
    Copy the full SHA
    4b298d1 View commit details
    Browse the repository at this point in the history

  3. use const for userID

    @ad-astra-via
    ad-astra-via committed May 27, 2024
    Configuration menu
    Copy the full SHA
    f38cc74 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. remove client.set of user_id

    @ad-astra-via
    ad-astra-via committed May 28, 2024
    Configuration menu
    Copy the full SHA
    4d55563 View commit details
    Browse the repository at this point in the history