Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assert noreturn on clang #944

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Fix assert noreturn on clang #944

merged 2 commits into from
Nov 8, 2023

Conversation

Qwinci
Copy link
Contributor

@Qwinci Qwinci commented Nov 4, 2023 •
edited
Loading

Atleast on clang [[noreturn]] is not the same as __attribute__((__noreturn__)) used in the header and it fails to compile because of that.

@Qwinci Qwinci changed the title Fix assert noreturn no clang Fix assert noreturn on clang Nov 4, 2023
Dennisbonke
Dennisbonke approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dennisbonke Dennisbonke merged commit 5108e5b into managarm:master Nov 8, 2023
25 checks passed
@Qwinci Qwinci deleted the fix-assert-noreturn branch February 8, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dennisbonke Dennisbonke Dennisbonke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qwinci @Dennisbonke