managarm: send mode in openat to posix #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error only has a defined value for GNU/Hurd, however it some systems (such as managarm) may find it useful to return internal errors.
ElectrodeYT
force-pushed
the
openat_fix_1
branch
from
56b1943
to
0aa7b74
Compare
At the moment, this error is only returned if the chmod that is fired when O_CREAT is used failes.
ElectrodeYT
force-pushed
the
openat_fix_1
branch
from
0aa7b74
to
ec461d4
Compare
qookei
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where if a file is crated with open or openat, it will not have any permission modes.
More importantly, this removes about 50% of log spam.
Managarm PR: managarm#568