options/posix: Add support for IPv6 addresses in inet_pton #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: 48cf <[email protected]>
Geertiebear
requested changes
Dec 29, 2024
| auto addr6 = reinterpret_cast<struct in6_addr*>(dst); | ||
|
|
||
| for(int i = 0; i < 8; i++) { | ||
| addr6->s6_addr16[i] = addr[i]; |
There was a problem hiding this comment.
Can we not just work directly into this array?
| int array_len = 0; | ||
|
|
||
| src = abbrev + 2; | ||
| while(*src) { |
There was a problem hiding this comment.
Why is this case basically copy pasted from the above one? Can they not be merged?
| } | ||
|
|
||
| if(abbrev) { | ||
| uint16_t array[8] = {}; |
There was a problem hiding this comment.
This seems broken, the array this block writes into goes out of scope before we can write it into the user provided argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@48cf can you add the tests you had for this to this (or a separate) PR please?
Part of the systemd on Linux project.