Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Remove crypt/iconv/intl stubs #1164

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

mintsuki
Copy link
Contributor

No description provided.

@mintsuki mintsuki force-pushed the no-crypt-iconv-intl branch from fd29bf6 to 2a7401f Compare October 16, 2024 09:27
@mintsuki mintsuki force-pushed the no-crypt-iconv-intl branch from 2a7401f to e127c82 Compare October 16, 2024 09:37
@mintsuki
Copy link
Contributor Author

lib{crypt,iconv,intl} were stubs only and no one should have been using them as opposed to proper GNU libiconv, libintl (from gettext), and libxcrypt (or equivalent). The ABI break failure is expected.

Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mintsuki mintsuki merged commit fb9b3db into managarm:master Oct 16, 2024
39 of 40 checks passed
@no92
Copy link
Member

no92 commented Oct 17, 2024

Why did this get merged when this is an ABI break?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants