Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysdeps/managarm: handle directoryNotEmpty error from rmdir #1069

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

ElectrodeYT
Copy link
Member

@ElectrodeYT ElectrodeYT commented May 31, 2024

Depends on managarm#671

Copy link
Member

@no92 no92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

specifically, this adds handling for DIRECTORY_NOT_EMPTY (ENOTEMPTY),
INTERNAL_ERROR (EIEIO), and NOT_A_DIRECTORY (ENOTDIR).
Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the abi checker is a false positive, this PR isn't fully rebased on master and getsubopt was added recently.

@Dennisbonke Dennisbonke merged commit 0ba500c into managarm:master Jun 1, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants