Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions for dhcpcd on managarm #1062

Merged
merged 15 commits into from
May 27, 2024
Merged

Additions for dhcpcd on managarm #1062

merged 15 commits into from
May 27, 2024

Conversation

no92
Copy link
Member

@no92 no92 commented May 10, 2024

Depends on managarm/managarm#662.

@no92
Copy link
Member Author

no92 commented May 11, 2024

This PR is complete now, and is ready to be reviewed; however, managarm/managarm#662 needs to be merged first.

@no92 no92 marked this pull request as ready for review May 11, 2024 12:58
Copy link
Member

@ElectrodeYT ElectrodeYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but one minor nitpick im not that sure about

sysdeps/managarm/generic/ioctl.cpp Show resolved Hide resolved
@no92
Copy link
Member Author

no92 commented May 15, 2024

This PR now includes the ioctls implemented in #935, superseding it once merged.

Copy link
Member

@ElectrodeYT ElectrodeYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qookei qookei merged commit 5075052 into managarm:master May 27, 2024
13 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants