-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additions for dhcpcd
on managarm
#1062
Conversation
This PR is complete now, and is ready to be reviewed; however, managarm/managarm#662 needs to be merged first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but one minor nitpick im not that sure about
This PR now includes the ioctls implemented in #935, superseding it once merged. |
Co-authored-by: no92 <[email protected]>
All 3 libcs that I checked seem to do this, and software seems to expect this to be the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Depends on managarm/managarm#662.