Add slice method to array #287
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-PLACET
force-pushed
the
add_slice_method_to_array
branch
from
5458b81
to
e283b91
Compare
DerThorsten
reviewed
Nov 14, 2024
| @@ -48,6 +49,13 @@ namespace sparrow | |||
| return array_element(*p_array, index); | |||
| } | |||
|
|
|||
| void array::slice(size_type start, size_type end) | |||
There was a problem hiding this comment.
I would prefer slice to return a array which is a view to the original array.
ie auto sliced_arr = arr.slice(start, end);
With the view function of the arrow_proxy it should be possible to create a cheap "view-copy" of the array and than change the offset and size there
Or maybe we should be explicit
auto sliced_arr = arr.slice(start, end); #deep copy
auto sliced_arr = arr.slice_view(start, end); #view
arr.slice_inplace(start, end) #modify
(not sure if the last one is needed or a good idea as mutating an array should be avoided if possible,imho)
DerThorsten
reviewed
Nov 14, 2024
| ar.slice(2, 8); | ||
|
|
||
| REQUIRE_EQ(ar.size(), 6); | ||
| CHECK_EQ(std::get<const_reference>(ar[0]), make_nullable<scalar_value_type>(2)); |
There was a problem hiding this comment.
we should add this to the consistency test instead of implementing this by hand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.