Better error message for non-increasing index. #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvoDD
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
IvoDD
force-pushed
the
parallel-writes-error-message
branch
from
9ca644f
to
0714c53
Compare
poodlewars
previously approved these changes
Oct 14, 2024
|
I don't think we realised that this error would be user facing when we first added it, so it should have a proper user facing error type rather than raising an internal error. |
IvoDD
force-pushed
the
parallel-writes-error-message
branch
4 times, most recently
from
870dfbe
to
1e8d10a
Compare
Attempting to write a non-increasing index version is most likely due to parallel writes to the same symbol. We now indicate that in the error message. Also introduces a new storage error type for parallel writes.
IvoDD
force-pushed
the
parallel-writes-error-message
branch
from
1e8d10a
to
c978a47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to write a non-increasing index version is most likely due to parallel writes to the same symbol. We now indicate that in the error message.
Reference Issues/PRs
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...