-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement on-the-fly descriptor calculation #630
Draft
RandomDefaultUser
wants to merge
17
commits into
mala-project:develop
Choose a base branch
from
RandomDefaultUser:descriptors_on_the_fly
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Implement on-the-fly descriptor calculation #630
RandomDefaultUser
wants to merge
17
commits into
mala-project:develop
from
RandomDefaultUser:descriptors_on_the_fly
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just looked into the DDP side of things. The problem here seems to be that DDP allocates the GPU for its own usage, so when LAMMPS wants to use them, they are not free. This should still be solvable, but requires more modification in the code. I will first address the other open issues and address this issue later on, maybe in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives MALA the capability to compute descriptors on the fly. In doing so, it allows for more refined hyperparameter optimization of descriptor related hyperparameters, since the training-free methods we initially envisioned may not (yet) be enough in many cases. The starting point for this on-the-fly methods are the .json files the DataConverter class can generate.
Since this is a pretty fundamental change in the MALA pipeline, it requires thorough testing. Namely, the following capabilities have to be implemented: