Add arbitrary shuffling for openPMD input #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomDefaultUser
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Looks good to me! There is one small caveat, which I think is inconsequential: The shuffled snapshots in the arbitrary mode are not identical for numpy and openpmd. I think that does not matter much, since we only care about randomizing data, not having the exact same randomization. But I wanted to mention it to document it for future reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shuffling openPMD data so far worked only if the number of output snapshots cleanly divides the first dimension of the input data. This PR overcomes that restriction.
TODO: