Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed loading method in ASE calculator #588

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Renamed loading method in ASE calculator #588

merged 2 commits into from
Oct 21, 2024

Conversation

RandomDefaultUser
Copy link
Member

Closes #566, see discussion on the matter there.

@RandomDefaultUser RandomDefaultUser marked this pull request as ready for review October 18, 2024 10:17
elcorto
elcorto approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@elcorto elcorto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks. FutureWarning is indeed better fitting than DeprecationWarning.

@RandomDefaultUser RandomDefaultUser merged commit 8e87783 into mala-project:develop Oct 21, 2024
5 checks passed
@RandomDefaultUser RandomDefaultUser deleted the rename_ase_calculator_loading branch October 21, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elcorto elcorto elcorto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API inconsistencies when saving and loading model snapshots
2 participants
@RandomDefaultUser @elcorto