Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requeue zombie trials #520

Merged
merged 3 commits into from
May 30, 2024

Conversation

elcorto
Copy link
Member

@elcorto elcorto commented May 30, 2024

Closes #497

The test works, the only strange thing which is a bit unclear is documented in this comment.

@elcorto elcorto requested a review from RandomDefaultUser May 30, 2024 14:15
@elcorto elcorto marked this pull request as draft May 30, 2024 14:24
Explain that changing Optuna trial states via
study._storage.set_trial_state_values() only works if state is not
COMPLETE.
@elcorto
Copy link
Member Author

elcorto commented May 30, 2024

Comment updated and resolved.

@elcorto elcorto marked this pull request as ready for review May 30, 2024 14:31
Copy link
Member

@RandomDefaultUser RandomDefaultUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@RandomDefaultUser RandomDefaultUser merged commit a9c219e into develop May 30, 2024
6 checks passed
@elcorto elcorto deleted the feature-fix-requeue-zombie-trials branch June 7, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optuna v3.x.x no longer compatible with zombie trial cleaning
2 participants