Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible TEM build silent fail #472

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Fix possible TEM build silent fail #472

merged 2 commits into from
Aug 4, 2023

Conversation

elcorto
Copy link
Member

@elcorto elcorto commented Aug 1, 2023

Closes #469

elcorto added 2 commits July 27, 2023 19:42
@elcorto
Fix silent fail when grep doesn't find a match
a968c01 
This can happen when e.g. the `find` before produces an empty result.
@elcorto
Cleanup in build_total_energy_module.sh
1c40d69 
Remove out-commented code, fix typo.
@elcorto
Copy link
Member Author

elcorto commented Aug 1, 2023

CPU tests / cpu-tests failed b/c of mala-project/test-data#6. However building locally works.

RandomDefaultUser
RandomDefaultUser approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@RandomDefaultUser RandomDefaultUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, this can be merged.

@RandomDefaultUser RandomDefaultUser merged commit 17747bd into mala-project:develop Aug 4, 2023
@elcorto elcorto deleted the feature-fix-tem-build-silent-fail branch August 31, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomDefaultUser RandomDefaultUser RandomDefaultUser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build_total_energy_module.sh can silently fail
2 participants
@elcorto @RandomDefaultUser