-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI for openPMD #449
CI for openPMD #449
Conversation
lfs = true ???
Update openPMD version in Dockerfile Add openPMD output to clean.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I have some inline comments.
Given that parallel shuffling is now merged, should we maybe test that, too?
# Conflicts: # mala/datahandling/data_shuffler.py
@franzpoeschel @RandomDefaultUser If openPMD is an optional dependency for MALA, it should not be part of |
I think we are moving for it not to be an optional dependency, so I would suggest we do the latter. I can open an issue for this. |
fixed by #541 |
This adds openPMD-api to the CI infrastructure and adds a test for openPMD. At the moment, that test is
test/shuffling_openpmd_test.py
which tests openPMD-based shuffling.It would be wise to add also a test that covers the basic functionality of openPMD I/O, especially also in parallel. Is there a test that uses numpy so far which I can modify to that purpose?